Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix normal h2 with gzip data #2335

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix normal h2 with gzip data #2335

merged 1 commit into from
Aug 2, 2023

Conversation

leaf-potato
Copy link
Contributor

@leaf-potato leaf-potato commented Jul 30, 2023

What problem does this PR solve?

Issue Number: #2334

Problem Summary: 非grpc的h2协议无法解析gzip数据。

What is changed and the side effects?

Changed: 当使用h2+gzip访问brpc server时,能正确解压数据并反序列化。

Side effects:

  • Performance effects(性能影响): 无

  • Breaking backward compatibility(向后兼容性): 是


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wasphin
Copy link
Member

wasphin commented Jul 31, 2023

LGTM

@wwbmmm wwbmmm merged commit 8239f6c into apache:master Aug 2, 2023
@leaf-potato leaf-potato deleted the h2_gzip branch August 2, 2023 14:16
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants