Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wireshark dissector for baidu_std protocol #2408

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Add wireshark dissector for baidu_std protocol #2408

merged 8 commits into from
Oct 17, 2023

Conversation

wasphin
Copy link
Member

@wasphin wasphin commented Oct 10, 2023

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响): N/A

  • Breaking backward compatibility(向后兼容性): N/A

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wasphin wasphin marked this pull request as draft October 10, 2023 15:56
@wasphin
Copy link
Member Author

wasphin commented Oct 11, 2023 •
edited
Loading

image

在 wireshark 中勾选后可以使用相关字段进行过滤
image

如： pbf.brpc.StreamFrameMeta.stream_id == 2 过滤指定流。
image

@wasphin wasphin marked this pull request as ready for review October 11, 2023 09:34
@wasphin wasphin changed the title WIP: Add wireshark dissector for baidu_std protocol Add wireshark dissector for baidu_std protocol Oct 11, 2023
@chenBright
Copy link
Contributor

印象中，好像需要将pb文件放到指定位置？

@wasphin
Copy link
Member Author

wasphin commented Oct 11, 2023

对，没有统一位置，得用户设置，然后把文件拷过去

@chenBright
Copy link
Contributor

body部分pb的解析，难点在于message不确定和message类型多样，这个能解决吗？

@wasphin
Copy link
Member Author

wasphin commented Oct 11, 2023

rpc 部分根据 service name 和 method 应该可以确认 message 类型，streaming 部分不太好处理。

@chenBright
Copy link
Contributor

那可以先将rpc部分实现了

@wasphin
Copy link
Member Author

wasphin commented Oct 12, 2023

image
image

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 13, 2023

文件名改成 wireshark_baidu_std.lua 是不是更清晰？另外加个文档说明？

@wasphin
Copy link
Member Author

wasphin commented Oct 13, 2023

周末我补个吧

@wasphin wasphin closed this Oct 16, 2023
@wasphin wasphin deleted the feature/dissector branch October 16, 2023 03:47
@wasphin wasphin reopened this Oct 16, 2023
@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 16, 2023

LGTM

@wasphin wasphin merged commit 12d0728 into apache:master Oct 17, 2023
32 checks passed
@AnDiXL AnDiXL mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenBright chenBright chenBright left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wasphin @chenBright @wwbmmm