-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async logging #2413
Merged
Merged
Support async logging #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenBright
force-pushed
the
async_logging
branch
4 times, most recently
from
October 15, 2023 08:02
982042e
to
563a267
Compare
chenBright
force-pushed
the
async_logging
branch
from
October 15, 2023 11:41
563a267
to
4aa16db
Compare
wwbmmm
reviewed
Oct 18, 2023
chenBright
force-pushed
the
async_logging
branch
from
October 23, 2023 15:02
5ba3613
to
aa58303
Compare
LGTM |
请问这个日志名字是怎么定义的,日志会根据大小切分吗 |
日志名通过butil::InitLogging LoggingSettings设置 Lines 244 to 280 in 2098dd3
|
目前框架不支持日志滚动,需要用户自己实现日志滚动逻辑,然后在LoggingLock的保护下更换log_file。 不过,很多日志库都支持日志滚动。框架支持日志滚动特性应该是个合理的需求。 |
|
chenBright
force-pushed
the
async_logging
branch
from
January 1, 2024 08:09
b91fb5e
to
be401a4
Compare
LGTM |
当日志打印频率比较低的时候,异步日志有可能退化为每个日志都包含两个动作:signal异步日志线程、异步日志线程落盘。 |
LGTM |
jiangdongzi
pushed a commit
to jiangdongzi/brpc
that referenced
this pull request
Jan 31, 2024
* Support async logging * Set max async log queue size * Flush async log before exit * Use sync log for the first LogRequest * Support usec of logging for macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
What is changed and the side effects?
Changed:
使用ExecutionQueue的相关技术支持异步日志
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: