fix DirReaderPosix close same fd twice #2415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
DirReaderPosix
析构时关闭只应调用closedir(dir_)
, 不应同时调用close(fd_)
, 否则会导致同一个fd
被close 两次。https://man.freebsd.org/cgi/man.cgi?query=fdopendir&sektion=3
https://pubs.opengroup.org/onlinepubs/9699919799/functions/fdopendir.html
PoC :
如果在
close(fd_)
和closedir(dir_)
之间有新的open
操作,fd_
可能会被复用,则closedir(dir_)
导致该新 open 的fd_
失效,后续对fd_
的操作将会导致errno = 9 (Bad File Descriptor)
错误。ps: 实际情况可能是在多个线程中触发,这里以单线程代码说明:
What is changed and the side effects?
Changed:
~DirReaderUnix() 中只需调用
closedir(dir_)
即可.Side effects:
No
No
Check List: