Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzing move fuzz test in main repo add more fuzz test #2420

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

0x34d
Copy link
Contributor

@0x34d 0x34d commented Oct 20, 2023

Move oss-fuzz brpc code into main repo.

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 23, 2023

What's in test/fuzzing/fuzz_*_seed_corpus.zip? Apache projects should try not to include binary files.

@0x34d
Copy link
Contributor Author

0x34d commented Oct 23, 2023

What's in test/fuzzing/fuzz_*_seed_corpus.zip? Apache projects should try not to include binary files.

seed-corpus for oss-fuzz .

I can unzip the file and then upload it if this sounds good.

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 25, 2023

It's better to unzip the file

@0x34d
Copy link
Contributor Author

0x34d commented Oct 25, 2023

It's better to unzip the file

Done.

@0x34d
Copy link
Contributor Author

0x34d commented Oct 25, 2023

I Don't think it's a good idea to add a license in seed files.

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 27, 2023

@wasphin Can the license checker skip checking the seed files?

@wasphin
Copy link
Member

wasphin commented Oct 27, 2023

license checking for the seed file can be excluded in https://github.com/apache/brpc/blob/master/.licenserc.yaml

Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com>
@0x34d
Copy link
Contributor Author

0x34d commented Oct 27, 2023

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 27, 2023

LGTM

@wwbmmm wwbmmm merged commit 38661fe into apache:master Jan 23, 2024
18 checks passed
DavidKorczynski pushed a commit to google/oss-fuzz that referenced this pull request Jan 24, 2024
Base PR apache/brpc#2420 ;

NOTE:
I can't enable memory sanitizer due to

```log
BAD BUILD: /tmp/not-out/tmpmptlk01q/fuzz_esp seems to have either startup crash or exit:
/tmp/not-out/tmpmptlk01q/fuzz_esp -rss_limit_mb=2560 -timeout=25 -seed=1337 -runs=4 < /dev/null
Uninitialized bytes in MemcmpInterceptorCommon at offset 15 inside [0x7030000000f0, 19)
==428==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x682b90 in __interceptor_memcmp /src/llvm-project/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:892:10
    #1 0x7fa8ef4cf62a in google::protobuf::SimpleDescriptorDatabase::DescriptorIndex<std::pair<void const*, int> >::FindLastLessOrEqual(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x15062a) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68)
    #2 0x7fa8ef4d259f in google::protobuf::SimpleDescriptorDatabase::DescriptorIndex<std::pair<void const*, int> >::AddSymbol(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::pair<void const*, int>) (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x15359f) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68)
    #3 0x7fa8ef4d2a15 in google::protobuf::SimpleDescriptorDatabase::DescriptorIndex<std::pair<void const*, int> >::AddFile(google::protobuf::FileDescriptorProto const&, std::pair<void const*, int>) (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x153a15) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68)
    #4 0x7fa8ef4cebef in google::protobuf::EncodedDescriptorDatabase::Add(void const*, int) (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x14fbef) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68)
    #5 0x7fa8ef499f43 in google::protobuf::DescriptorPool::InternalAddGeneratedFile(void const*, int) (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x11af43) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68)
    #6 0x7fa8ef49281d in protobuf_google_2fprotobuf_2fapi_2eproto::AddDescriptorsImpl() (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x11381d) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68)
```

Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com>
jiangdongzi pushed a commit to jiangdongzi/brpc that referenced this pull request Jan 31, 2024
Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants