Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow copy and assign of Channel #2439

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

禁用Channel拷贝和赋值操作:

  1. 拷贝得到Channel并一定能使用(不知道是否Init)
  2. 拷贝后,未再次执行SocketMapInsert令_server_id的引用计数加一。这样,只要有一个Channel析构了,就会将_server_id从SocketMap里删除,其他Channel副本的RPC调用都会失败。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm wwbmmm merged commit bef942b into apache:master Nov 10, 2023
18 checks passed
@chenBright chenBright deleted the channel_disable_copy branch November 10, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants