Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support memory builtin service #2505

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright
Copy link
Contributor Author

127 0 0 1_8000_tcmalloc

@chenBright chenBright changed the title Support TCMalloc service Support TCMalloc builtin service Jan 14, 2024
@jamesge
Copy link
Contributor

jamesge commented Jan 15, 2024

这个要考虑成为memory service么?(/memory),那样的话似乎比较适合以后适配新的allocator

@chenBright chenBright changed the title Support TCMalloc builtin service Support memory builtin service Jan 16, 2024
@chenBright
Copy link
Contributor Author

这个要考虑成为memory service么?(/memory),那样的话似乎比较适合以后适配新的allocator

已经改成memory service

@wwbmmm
Copy link
Contributor

wwbmmm commented Jan 17, 2024

LGTM

@wwbmmm wwbmmm merged commit df69b95 into apache:master Jan 23, 2024
18 checks passed
@chenBright chenBright deleted the tcmalloc_service branch January 23, 2024 06:28
jiangdongzi pushed a commit to jiangdongzi/brpc that referenced this pull request Jan 31, 2024
* Support TCMalloc builtin service

* Support memory service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants