Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : ELEMENTS_PER_BLOCK may be incorrect #2562

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

shanhe72101
Copy link
Contributor

What problem does this PR solve?

Issue Number:#2561

Problem Summary:

推测常量ELEMENTS_PER_BLOCK本意是一页可以容纳DoublyBufferedData::Wrapper的个数,误写成了sizeof(T)
DoublyBufferedData::Wrapper增加BAIDU_CACHELINE_ALIGNMENT修饰,避免伪共享

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@shanhe72101 shanhe72101 changed the title Fix bug doubly buffered data Fix : ELEMENTS_PER_BLOCK may be incorrect Mar 5, 2024
@wwbmmm
Copy link
Contributor

wwbmmm commented Mar 11, 2024

LGTM

Copy link
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright chenBright merged commit 216aa59 into apache:master Mar 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants