Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support on_failed callback for streaming rpc #2565

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number: resolve #2285

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright changed the title Split closed and failed streaming rpc Support on_failed callback for streaming rpc Mar 10, 2024
src/brpc/stream.h Outdated Show resolved Hide resolved
@chenBright chenBright force-pushed the stream_on_failed branch 5 times, most recently from 1fe7dac to 4c474b9 Compare March 11, 2024 15:16
@wwbmmm
Copy link
Contributor

wwbmmm commented Mar 18, 2024

LGTM

@wwbmmm wwbmmm merged commit 337142f into apache:master Apr 8, 2024
18 checks passed
@chenBright chenBright deleted the stream_on_failed branch April 8, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream感知正常和异常关闭
2 participants