-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support connect on socket create #2574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenBright
force-pushed
the
connect_on_create
branch
from
March 17, 2024 16:23
ff76e27
to
8e98563
Compare
wwbmmm
reviewed
Mar 18, 2024
LGTM |
chenBright
force-pushed
the
connect_on_create
branch
2 times, most recently
from
March 26, 2024 14:52
64b66af
to
2ee220d
Compare
Socket在Create中建连成功后,Address获取Socket指针之前,连接有可能出错,导致Socket被回收,健康检查无法被使能。所以,将持有健康检查引用提前到Create中,并将健康检查引用持有和释放的逻辑封装到函数中,方便使用。 |
@chenBright 和主干冲突了 |
chenBright
force-pushed
the
connect_on_create
branch
from
April 1, 2024 12:24
2ee220d
to
ddb058f
Compare
@wwbmmm done |
LGTM |
Open
chenBright
force-pushed
the
connect_on_create
branch
2 times, most recently
from
April 28, 2024 14:23
82ae010
to
103e5f0
Compare
解决与master的冲突 |
@chenBright 又冲突了。。 |
chenBright
force-pushed
the
connect_on_create
branch
from
June 11, 2024 03:46
103e5f0
to
f806df9
Compare
@wwbmmm done,rebase解决冲突。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
目前直接使用client Socket,存在两个问题:
What is changed and the side effects?
Changed:
支持在Socket::Create中连接对端,同时支持ssl。
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: