Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail at field type mismatch in json2pb #2608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PeterRK
Copy link

@PeterRK PeterRK commented Apr 20, 2024

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:
json2pb中遇到字段类型不匹配时的处理方式由跳过改为报错,以避免引发后续隐藏错误。

Side effects:

  • Performance effects(性能影响):
  • Breaking backward compatibility(向后兼容性):
    对一种此前被忽略的错误会报出

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright
Copy link
Contributor

补充一下UT吧

@chenBright
Copy link
Contributor

提供一个option来支持该特性,是不是合适些?这样就不会影响已有的逻辑了。

@wwbmmm
Copy link
Contributor

wwbmmm commented Apr 22, 2024

提供一个option来支持该特性,是不是合适些?这样就不会影响已有的逻辑了。

+1

@chenBright
Copy link
Contributor

master分支已经修复了ci的问题,可以更新一下PR。

@PeterRK
Copy link
Author

PeterRK commented Apr 23, 2024

提供一个option来支持该特性,是不是合适些?这样就不会影响已有的逻辑了。

这应该是一个bug,原来的实现中string、bool、int32、uint32四种类型没有返回错误,int64、uint64、float、double、enum、object则会返回错误。统一都返回错误才是合理的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants