Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect core file in run_tests.sh #2614

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

chenBright
Copy link
Contributor

@chenBright chenBright commented Apr 25, 2024

What problem does this PR solve?

Issue Number:

brpc/test/run_tests.sh

Lines 37 to 44 in 6a335aa

print_bt () {
# find newest core file
COREFILE=$(find . -name "core*" -type f -printf "%T@ %p\n" | sort -k 1 -n | cut -d' ' -f 2- | tail -n 1)
if [ ! -z "$COREFILE" ]; then
>&2 echo "corefile=$COREFILE prog=$1"
gdb -c "$COREFILE" $1 -ex "thread apply all bt" -ex "set pagination 0" -batch;
fi
}

run_tests.sh中有问题,认为最新的core文件一定是失败的ut生成的,但是ci中出现了对不上的情况:

1 FAILED TEST
corefile=./core.test_butil.8086 prog=brpc_grpc_protocol_unittest

Problem Summary:

What is changed and the side effects?

Changed:

先将旧的core文件删除。

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright force-pushed the fix_run_tests branch 9 times, most recently from 97bc14f to d42a1a2 Compare April 27, 2024 09:27
@wwbmmm wwbmmm merged commit 7230347 into apache:master Apr 29, 2024
20 checks passed
@chenBright chenBright deleted the fix_run_tests branch April 29, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants