Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FlatMap assign operator bug #2622

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

chenBright
Copy link
Contributor

@chenBright chenBright commented Apr 28, 2024

What problem does this PR solve?

Issue Number:

Problem Summary:

butil::FlatMap<int, int> m1;
if (m1.init(32) != 0) {}
butil::FlatMap<int, int> m2 = m1;

FLatMap::operator=的逻辑有问题,即使m1已经初始化了,但是因为m1是空的,所以将m1赋值给m2后,m2仍然是未初始化的,一旦被使用,基本上就会出core。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm wwbmmm merged commit f97cbe5 into apache:master Apr 29, 2024
20 checks passed
@chenBright chenBright deleted the fix_flat_map branch April 29, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants