Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: switch between stream_rpc and baidu_std #2678

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

howarlii
Copy link
Contributor

@howarlii howarlii commented Jul 3, 2024

What problem does this PR solve?

Issue Number: #2677

Problem Summary: under baidu_std, server can not parse message when normal PRC and stream RPC arrive simultaneously

What is changed and the side effects?

Changed: switch between baidu_std and stream_rpc in InputMessenger::CutInputMessage

Side effects:

  • Performance effects(性能影响): Little or none

  • Breaking backward compatibility(向后兼容性): no


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Jul 4, 2024

UT failed:

brpc_streaming_rpc_unittest.cpp:254: Failure
Expected equality of these values:
  0
  brpc::StreamWrite(request_stream, out)
    Which is: 11

@howarlii
Copy link
Contributor Author

howarlii commented Jul 5, 2024

这个似乎是UT的概率fail问题,main上的UT也是fail的

@wwbmmm
Copy link
Contributor

wwbmmm commented Jul 6, 2024

LGTM

@Huixxi Huixxi merged commit fdc60ba into apache:master Jul 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants