Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gdb_bthread_stack.py not recognize type name #2732

Merged

Conversation

ehds
Copy link
Contributor

@ehds ehds commented Aug 9, 2024

What problem does this PR solve?

Issue Number:

#2674

Problem Summary:

gdb_bthread_stack.py 调试时带有 template 的class 需要用单引号包裹,避免出现找不到符号的错误

butil::ResourcePool<bthread::TaskMeta>::_ngroup 使用强转成整型

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@ehds ehds changed the title wrap the class name in single quotes fix gdb_bthread_stack.py not recognize type name Aug 9, 2024
@wwbmmm
Copy link
Contributor

wwbmmm commented Aug 19, 2024

LGTM

@ehds ehds changed the title fix gdb_bthread_stack.py not recognize type name WIP: fix gdb_bthread_stack.py not recognize type name Aug 19, 2024
@wwbmmm
Copy link
Contributor

wwbmmm commented Sep 26, 2024

@ehds 这个PR还有需要修改的地方吗?看标题是WIP

@ehds
Copy link
Contributor Author

ehds commented Sep 27, 2024

@ehds 这个PR还有需要修改的地方吗?看标题是WIP

这个 PR 主要解决 #2674 提到的问题,在相同的环境下可以复现,使用现在修改后可以正常使用。但是 #2674 (comment) 提出会遇到另外的报错,但在我这边本地无法复现。

@yanglimingcn
Copy link
Contributor

@ehds 这个PR还有需要修改的地方吗?看标题是WIP

这个 PR 主要解决 #2674 提到的问题,在相同的环境下可以复现,使用现在修改后可以正常使用。但是 #2674 (comment) 提出会遇到另外的报错,但在我这边本地无法复现。

#2674 这个我这边复现了,用这个PR也可以解决。

@ehds ehds changed the title WIP: fix gdb_bthread_stack.py not recognize type name fix gdb_bthread_stack.py not recognize type name Oct 10, 2024
@ehds
Copy link
Contributor Author

ehds commented Oct 10, 2024

@ehds 这个PR还有需要修改的地方吗?看标题是WIP

这个 PR 主要解决 #2674 提到的问题,在相同的环境下可以复现,使用现在修改后可以正常使用。但是 #2674 (comment) 提出会遇到另外的报错,但在我这边本地无法复现。

#2674 这个我这边复现了,用这个PR也可以解决。

@wwbmmm @yanglimingcn 那这个PR先合入吧,后续有问题再继续优化。

@wwbmmm wwbmmm merged commit 8d8a296 into apache:master Oct 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants