-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arena rpc pb message factory #2751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenBright
force-pushed
the
arena_pb_factory
branch
from
September 1, 2024 14:41
13acb01
to
4fad729
Compare
chenBright
force-pushed
the
arena_pb_factory
branch
from
September 2, 2024 04:58
4fad729
to
1af9607
Compare
wwbmmm
reviewed
Sep 2, 2024
chenBright
force-pushed
the
arena_pb_factory
branch
from
September 2, 2024 12:05
f60bc07
to
52400da
Compare
chenBright
force-pushed
the
arena_pb_factory
branch
from
September 2, 2024 13:19
52400da
to
5265d4b
Compare
yanglimingcn
reviewed
Sep 3, 2024
yanglimingcn
reviewed
Sep 3, 2024
chenBright
force-pushed
the
arena_pb_factory
branch
from
September 3, 2024 03:06
1e16c2d
to
56c4a57
Compare
LGTM |
有遇到过,这样设置之后,只要有流量,内存一致上涨OOM的情况吗 |
@chenBright 哦,看着应该可以了。 昨天看代码排查时候,感觉可能是arena直接放入对象池导致的,后来直接改成new/delete验证了下,看着是ok的。上午按你给的pr更新了下,目前观察看着是ok的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve #535
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: