Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Protobuf to v27.3 for building with bzlmod #2823

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

wasphin
Copy link
Member

@wasphin wasphin commented Nov 18, 2024

After using offical boost 1.83.0[1], rules_cc@0.0.13 are required, which, in turn, requires Protobuf v27.0.

Protobuf v27.0 is not compatible with GCC less than 13[2].

[1] #2789
[2] protocolbuffers/protobuf#16868

What problem does this PR solve?

Issue Number: #2822

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

After using offical boost 1.83.0[1], rules_cc@0.0.13 are required,
which, in turn, requires Protobuf v27.0.

Protobuf v27.0 is not compatible with GCC less than 13[2].

[1] apache#2789
[2] protocolbuffers/protobuf#16868
@wwbmmm wwbmmm merged commit 72ce354 into apache:master Nov 19, 2024
20 checks passed
@wasphin wasphin deleted the feature/fix-ci branch November 19, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants