New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak issue #2871 #2872

Open

w-gc wants to merge 6 commits into apache:master from w-gc:master

w-gc commented Jan 13, 2025

What problem does this PR solve?

Issue Number: #2871

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

w-gc force-pushed the master branch from b54e66d to 001bea2 Compare

January 13, 2025 10:47

chenBright linked an issue

that may be closed by this pull request

[Bug] Memory leak about ServerOptions #2871

Open

chenBright reviewed

View reviewed changes

src/brpc/server.cpp Outdated Show resolved Hide resolved

Contributor

chenBright commented Jan 13, 2025

This PR caused the BuiltinServiceTest.customized_health unit test to fail.

yanglimingcn reviewed

View reviewed changes

src/brpc/server.cpp Show resolved Hide resolved

chenBright reviewed

View reviewed changes

src/brpc/server.cpp Outdated Show resolved Hide resolved

w-gc requested review from chenBright and yanglimingcn

January 15, 2025 03:55

w-gc force-pushed the master branch from 3133274 to 2c9e0b0 Compare

January 15, 2025 09:53


          fix memory leak issue

237146a

w-gc force-pushed the master branch from 2c9e0b0 to 237146a Compare

January 16, 2025 07:41

chenBright reviewed

View reviewed changes

src/brpc/server.cpp Outdated Show resolved Hide resolved

w-gc requested a review from chenBright

January 20, 2025 02:50


          add comments

9ed8b8a

chenBright approved these changes

View reviewed changes

Contributor

chenBright left a comment

LGTM

yanglimingcn reviewed

View reviewed changes

src/brpc/server.cpp Outdated Show resolved Hide resolved

yanglimingcn reviewed

View reviewed changes

src/brpc/server.cpp Outdated Show resolved Hide resolved

yanglimingcn reviewed

View reviewed changes

src/brpc/server.cpp Show resolved Hide resolved


          refine

f286fa4

w-gc requested a review from yanglimingcn

January 23, 2025 03:43

w-gc added 2 commits

January 24, 2025 10:46


          refine

634f0e3

fix

w-gc requested a review from chenBright

January 24, 2025 05:00


          continue to fix

a58b1f8

chenBright approved these changes

View reviewed changes

Contributor

chenBright left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet