bug fix: consul ns thread can not quit #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesge
reviewed
Nov 28, 2018
| @@ -234,6 +234,10 @@ int ConsulNamingService::RunNamingService(const char* service_name, | |||
| return -1; | |||
| } | |||
| } | |||
| if (errno == EINTR) { | |||
There was a problem hiding this comment.
为什么把errno的判定放这里？只要前面的函数不设errno，或没有返回-1，errno都没有意义
jamesge
reviewed
Nov 29, 2018
| @@ -234,6 +234,10 @@ int ConsulNamingService::RunNamingService(const char* service_name, | |||
| return -1; | |||
| } | |||
| } | |||
| if (bthread_stopped(bthread_self())) { | |||
There was a problem hiding this comment.
rc != 0的情况下，也有可能被stop了，bthread_usleep会成功不会退出，因为meta->interrupted已经false了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.