Pure python cython #1547
Draft
Pure python cython #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abderrahim
force-pushed
the
pure-python-cython
branch
2 times, most recently
from
605f430 to
11b5894
Compare
Fix lint and formatting errors in the process
Fix lint and formatting errors in the process
abderrahim
force-pushed
the
pure-python-cython
branch
from
11b5894 to
36e7d5d
Compare
nanonyme
reviewed
Feb 17, 2022
| @@ -72,11 +73,11 @@ def set_values(mcs, kls, data): | |||
|
|
|||
| type.__setattr__(kls, "_value_to_entry", value_to_entry) | |||
|
|
|||
| def __repr__(self): | |||
| return "<fastenum '{}'>".format(self.__name__) | |||
| def __repr__(cls): | |||
There was a problem hiding this comment.
Looks weird. This looks like it assumes it's a class method but there's no classmethod decorator. Is this change because it's a metaclass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proof of concept for #1412