workspace.py: Remove assumption on specific kinds to testing multiple

[BenjaminSchubert]

This makes the test more explicit in testing that it can actually open
multiple different projects at the same time, and removes the need of
actually using multiple kinds

[gtristan]

We added tests to ensure that by default we don’t stage the git/bzr history (when we made that behavior default), we should keep these assertions in some form somewhere.

[BenjaminSchubert]

We added tests to ensure that by default we don’t stage the git/bzr history (when we made that behavior default), we should keep these assertions in some form somewhere.

This PR doesn't change this. It merely removes a fuzzy validation that the workspace was opened correctly. We have tests in each of those sources that make sure of this.

[gtristan]

We added tests to ensure that by default we don’t stage the git/bzr history (when we made that behavior default), we should keep these assertions in some form somewhere.

This PR doesn't change this. It merely removes a fuzzy validation that the workspace was opened correctly. We have tests in each of those sources that make sure of this.

Technically this testing should be in the domain of the sources themselves, but do remember that some sources (probably git and bzr included) use different codepaths for opening a workspace than they do for merely staging sources (see Source.init_workspace()).

If this assertion exists for opening workspaces on git / bzr somewhere then lets immediately just remove these.

[BenjaminSchubert]

@gtristan absolutely:

For git, we have https://github.com/apache/buildstream/blob/master/tests/sources/git.py#L64-L86 that ensures we can successfully run git.

For bzr, we have https://github.com/apache/buildstream/pull/1565/files that also tangentially ensures we have a .bzr directory.

So merging this for now :) thanks!