Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-510] Support for grouping sets in AggregateExpandDistinctAggregatesRule #27

Closed
wants to merge 1 commit into from
Closed

[CALCITE-510] Support for grouping sets in AggregateExpandDistinctAggregatesRule #27

wants to merge 1 commit into from

Conversation

jcamachor
Copy link
Contributor

No description provided.

julianhyde
julianhyde reviewed Dec 10, 2014
View reviewed changes
core/src/main/java/org/apache/calcite/rel/rules/AggregateExpandDistinctAggregatesRule.java
import java.util.ArrayList;
import java.util.HashMap;
import java.util.LinkedHashSet;
import java.util.List;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These re-ordered imports -- and some other issues -- cause checkstyle to fail. "mvn clean install" (which includes checkstyle) must pass before you submit a pull request.

@jcamachor
Copy link
Contributor Author

@julianhyde, thanks for the comments. I have addressed them in the new commit: checkstyle passes, and the new method has been added to the Aggregate class.

@julianhyde
Copy link
Contributor

I get 3 test failures:

Failed tests: 
  RelOptRulesTest.testPushSumCountStarGroupingSetsThroughUnion:964->basePushAggThroughUnion:880->RelOptTestBase.checkPlanning:72->RelOptTestBase.checkPlanning:83->RelOptTestBase.checkPlanning:130 type mismatch:
aggCall type:
BOOLEAN NOT NULL
inferred type:
BIGINT NOT NULL
  RelOptRulesTest.testPushCountNullableGroupingSetsThroughUnion:946->basePushAggThroughUnion:880->RelOptTestBase.checkPlanning:72->RelOptTestBase.checkPlanning:83->RelOptTestBase.checkPlanning:130 type mismatch:
aggCall type:
BOOLEAN NOT NULL
inferred type:
BIGINT NOT NULL
  RelOptRulesTest.testPushCountStarGroupingSetsThroughUnion:941->basePushAggThroughUnion:880->RelOptTestBase.checkPlanning:72->RelOptTestBase.checkPlanning:83->RelOptTestBase.checkPlanning:130 type mismatch:
aggCall type:
BOOLEAN NOT NULL
inferred type:
BIGINT NOT NULL

@julianhyde
Copy link
Contributor

Oops. Ignore that. That is in CALCITE-502 branch.

@asfgit asfgit closed this in 2425885 Dec 11, 2014
@jcamachor jcamachor deleted the CALCITE-510 branch December 11, 2014 20:11
ldming pushed a commit to ldming/mycalcite that referenced this pull request Sep 13, 2018
@jcamachor @julianhyde
[CALCITE-510] Support for grouping sets in AggregateExpandDistinctAgg…
243eeb0 
…regatesRule (Jesus Camacho Rodriguez)

Close apache/calcite#27
olivrlee pushed a commit to olivrlee/calcite that referenced this pull request Mar 28, 2023
@tjbanghart
[CALCITE-5543] WIP: Implement BigQuery functions for parsing DATE, TI…
49cac0f 
…ME, TIMESTAMP, DATETIME (apache#27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcamachor @julianhyde