[CALCITE-6664] Replace GREATEST, LEAST functions in Spark library wit… #4090
+47
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobiGo
reviewed
Dec 13, 2024
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
|
NobiGo
reviewed
Dec 16, 2024
mihaibudiu
added
the
LGTM-will-merge-soon
|
please squash the commits so we can merge this |
…h the implementation of PostgreSQL Library
joeyutong
force-pushed
the
calcite-6664
branch
from
67bb77a to
75763c6
Compare
|
Commit Info needs to be consistent with Jira Summary and I think Jira summary is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GREATESTorLEASTfunction in Spark library returns null if any of its parameters are null, it is not consistent with the description of Spark docsThis PR tries to replacement the implementation of these functions with the implementation in PostgreSQL Library