Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove human-readable format from timer period computation in cron trait #1350

Closed
nicolaferraro opened this issue Mar 16, 2020 · 1 comment
Closed

Remove human-readable format from timer period computation in cron trait #1350

nicolaferraro opened this issue Mar 16, 2020 · 1 comment
Assignees
@oscerd
Labels
good first issue Does not require full understanding of the codebase

Comments

@nicolaferraro
Copy link
Member

Human readable format is no longer supported in Camel 3.2.x.

See:

camel-k/pkg/trait/cron.go

Line 100 in a8f8db9

camelTimerPeriodHumanReadable = regexp.MustCompile(`^(?:([0-9]+)h)?(?:([0-9]+)m)?(?:([0-9]+)s)?$`)

@nicolaferraro nicolaferraro added the good first issue Does not require full understanding of the codebase label Mar 16, 2020
@oscerd
Copy link
Contributor

oscerd commented Mar 16, 2020

If nobody want to work on this I'll have a look

oscerd added a commit that referenced this issue Mar 17, 2020
@oscerd
Fixes #1350 Remove human-readable format from timer period computatio…
d25005a 
…n in cron trait
oscerd added a commit that referenced this issue Mar 17, 2020
@oscerd
Fixes #1350 Remove human-readable format from timer period computatio…
3a0ce48 
…n in cron trait, e2e tests
oscerd added a commit that referenced this issue Mar 17, 2020
@oscerd
Fixes #1350 Remove human-readable format from timer period computatio…
6d46dab 
…n in cron trait, examples
oscerd added a commit that referenced this issue Mar 17, 2020
@oscerd
Fixes #1350 Remove human-readable format from timer period computatio…
a47410d 
…n in cron trait, templates
oscerd added a commit that referenced this issue Mar 17, 2020
@oscerd
Fixes #1350 Remove human-readable format from timer period computatio…
d513b8d 
…n in cron trait, more tests
@oscerd oscerd closed this as completed in f65e131 Mar 17, 2020
oscerd added a commit that referenced this issue Mar 17, 2020
@oscerd
Merge pull request #1352 from apache/issue-1350
b91e38d 
Fixes #1350 Remove human-readable format from timer period computatio…
oscerd added a commit that referenced this issue Mar 17, 2020
@oscerd
Fixes #1350 Remove human-readable format from timer period computatio…
6a877a4 
…n in cron trait, fixed README too
oscerd added a commit that referenced this issue Mar 17, 2020
@oscerd
Fixes #1350 Remove human-readable format from timer period computatio…
6355cc3 
…n in cron trait, fixed cr-example in deploy
oscerd added a commit that referenced this issue Mar 17, 2020
@oscerd
Fixes #1350 Remove human-readable format from timer period computatio…
94e7f2e 
…n in cron trait, fixed OLM catalog too
nicolaferraro added a commit that referenced this issue Mar 17, 2020
@nicolaferraro
Fix #1350: remove other places where the timer human readable format …
3f615b5 
…is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscerd oscerd

Labels
good first issue Does not require full understanding of the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolaferraro @oscerd