Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Service Binding operator to v0.5.0 #2077

Closed
astefanutti opened this issue Mar 1, 2021 · 11 comments
Closed

Upgrade to Service Binding operator to v0.5.0 #2077

astefanutti opened this issue Mar 1, 2021 · 11 comments

Comments

@astefanutti
Copy link
Member

v0.5.0 has just been released. #2076 prepares the ground by upgrading to an intermediate version, but v0.5.0 introduces breaking changes in the ServiceBinding API that should be integrated. See:

https://github.com/redhat-developer/service-binding-operator/releases/tag/v0.5.0

@astefanutti
Copy link
Member Author

/cc @johnpoth

@astefanutti astefanutti changed the title Upgrade to Service Binding operator v0.5.0 Upgrade to Service Binding operator to v0.5.0 Mar 1, 2021
@johnpoth
Copy link
Member

johnpoth commented Mar 1, 2021

That was fast! I can take a look

@arthurdm
Copy link

arthurdm commented Mar 2, 2021

I am interested in learning more about the connection and usage between Camel K and Service Binding, as I work on the Service Binding Spec. Any details that could be shared?

@astefanutti
Copy link
Member Author

@johnpoth
Copy link
Member

johnpoth commented Mar 4, 2021

There is also a meeting where use cases can be discussed. Next one is today at 1:00 PM UTC I think

johnpoth added a commit to johnpoth/camel-k that referenced this issue Mar 4, 2021
@johnpoth johnpoth mentioned this issue Mar 4, 2021
@johnpoth
Copy link
Member

johnpoth commented Mar 4, 2021

@arthurdm I think one part of the specification that is relevant here is the use of custom service projection where camel-k handles the mounting of the binding information (in the form of a secret) into the Deployment. I am mentioning this as it's scheduled to be removed if my understanding is correct.

One of the benefit of using this approach was that the Deployment did not have to be created in an incomplete state: waiting for the binding information and the resulting Pods failing.

Leveraging application-resource-mapping might let us achieve the same behavior.

@arthurdm
Copy link

arthurdm commented Mar 4, 2021

Thanks for link @astefanutti / @johnpoth!

Yes - are you noted, we're about to remove the CustomServiceProjection from the spec. In order to leverage the new ClusterApplicationResourceMapping artifact my recommendation would be to expose the needed elements (volumeMount, env, etc) in the .spec of Integration - so that we don't get into a reconciler loop when the Service Binding Operator changes the generated Deployment that is owned by the Camel K Operator.

@astefanutti
Copy link
Member Author

I've created #2096, as an umbrella issue to make Integration PodSpecable.

@johnpoth
Copy link
Member

johnpoth commented Mar 4, 2021

In the case of ServiceBinding, the integration isn't needed to be PodSpecable

@astefanutti
Copy link
Member Author

In the case of ServiceBinding, the integration isn't needed to be PodSpecable

It seems that was the case an hour ago 😉.

@astefanutti
Copy link
Member Author

Fixes with #2094.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants