Add delete integration option #100
Conversation
| if err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you add a feedback to the user also here?
There was a problem hiding this comment.
Good, thanks. Will add in case of no integrations to delete or number of deleted integrations
| Long: kamelCommandLongDescription, | ||
| Use: "kamel", | ||
| Short: "Kamel is a awesome client tool for running Apache Camel integrations natively on Kubernetes", | ||
| Long: kamelCommandLongDescription, |
There was a problem hiding this comment.
This will be reverted by gofmt, best if you set it up on your ide
There was a problem hiding this comment.
@lburgazzoli , sorry, this was done by vscode by default. Will try to set gofmt for it.
There was a problem hiding this comment.
@lburgazzoli it's very strange, but I got the same result when I tried to format manually with gofmt
There was a problem hiding this comment.
strange, when I do save in vscode, it gets automatically indented. In any case it is not an issue
pkg/client/cmd/delete.go
Outdated
| RunE: options.run, | ||
| } | ||
|
|
||
| cmd.Flags().StringVar(&options.integrationName, "name", "", "The integration name") |
There was a problem hiding this comment.
I guess we do not need an option for the integration to delete but you could use what the user input as args so you can delete multiple integration, like
kamel delete i1 i2 i3
There was a problem hiding this comment.
Ok, thanks will do this.
dmvolod
force-pushed
the
delete-integration
branch
from
cea84d7 to
87b8748
Compare
|
@lburgazzoli , @nicolaferraro fixed. Please review. |
|
I'm not included in the requested reviewer but I tested it and it works. |
|
@oscerd , sorry. missed you. Thanks for testing. |
Fixes #96