-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Knative broker/trigger model and explicit source/sink #1012
Support Knative broker/trigger model and explicit source/sink #1012
Conversation
@lburgazzoli it seems the error is related to the upgrade to runtime snapshot.
|
The test name seems to be misleading because actually it test the installation of the I've tested it locally and the kit is properly created so wondering if you have defined the snapshot repo in the test namespace. When running from the integration tests:
which is likely to be the snapshot repo not configured. I think that snapshot repos should always be enabled for e2e |
There was a lib not explicitly listed in the dev build pom (should work even without snapshot repo). |
@@ -0,0 +1,138 @@ | |||
package knative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add license header here.
7b155cf
to
df4436a
Compare
This aligns to the changes done in the runtime to support the broker/trigger model.
Marking as WIP because I want to add some integration tests with the broker.
Release Note