feat(trait): leverage ConfigMap binary data for resources #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
approved these changes
Feb 1, 2021
Do you mean this, right? what's the process to update them? |
Exactly. You can run Also running |
oscerd
approved these changes
Feb 1, 2021
|
@squakez it seems like there is a conflict with |
I'll rebase |
* Any binary data will be using BinaryData ConfiMap instead of Data. We let the cluster to encode/decode the resource * Any text resource will be still using the Data (plain) ConfigMap * The `compression` feature can be run both on binary and text resources, providing a base64 encoded file. * Added unit test to check all the possible scenarios Close apache#1946, close apache#1881
* Added integration test for apache#1946
With apache#1946 we are no longer needing a special `compress-binary` flag
Include rawContent and contentType for resources Ref apache#1946
squakez
force-pushed
the
feat/1946_binary_resources
branch
from
bb01230 to
2b4bd88
Compare
|
@astefanutti it should be clear now |
|
Thanks @squakez! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we include the possibility to use
BinaryDatainConfigMaps, leaving any encoding/decoding to the k8s platform. The decision of the usingBinaryDatavsDatais based on the sniffedmime-typeof the resource passed. In order to maintain the possibility to explicit encode we have the following situations:kamel run ... --resource file.text--> will leverageDataConfigMap, mounting a volume with a plain text data file.kamel run ... --resource file.binary-->will leverageBinaryDataConfigMap, mounting a volume with a binary data file.kamel run ... --resource file.text/file.binary --compression--> will leverageDataConfigMap, we base64 encode the content, mounting a volume with a base64 encoded file. Decoding will be up to the application logic.Close #1946, fix #1881
Release Note