fix: The KameletBinding readiness condition should mirror its Integration one

[astefanutti]

Fixes #3091.

This follows up #2682 and #2719.

Release Note

fix: The KameletBinding readiness condition should mirror its Integration one

[heiko-braun]

Thanks for the quick turnaround @astefanutti

[heiko-braun]

Out of curiosity, will this backported to a 1.8.x maintenance branch?

[astefanutti]

Out of curiosity, will this backported to a 1.8.x maintenance branch?

Yes, it's a left over from #2682 and #2719, which have been delivered in 1.8.0, so it makes sense to have it back ported.

[astefanutti]

Here are the transitioning statuses in the happy-path scenario, where a KameletBinding materialises into a Deployment resource:

status:
  conditions:
  - message: Integration "timer-binding" is in "Creating" phase
    reason: Creating
    status: "False"
    type: Ready
  phase: Creating

status:
  conditions:
  - message: Integration "timer-binding" readiness condition is "False"
    reason: DeploymentProgressing
    status: "False"
    type: Ready
  phase: Ready

status:
  conditions:
  - message: Integration "timer-binding" readiness condition is "True"
    reason: DeploymentReady
    status: "True"
    type: Ready
  phase: Ready

[astefanutti]

The e2e tests that cover the above are added with 2b24202.

[lburgazzoli]

@astefanutti

the examples you provided the conditions are those materialized in the KameletBinding status right ?
so to monitor the effective status of a KameletBinding the Ready condition should be taken into account.

if an error occurs on the deployment, i.e. it will exceed the progress limit, will an error surface ?

[astefanutti]

the examples you provided the conditions are those materialized in the KameletBinding status right ?

Right.

So to monitor the effective status of a KameletBinding the Ready condition should be taken into account.

Yes. I didn't change the KameletBinding phases, but I'd be inclined to eventually change the Ready phase to Running.

if an error occurs on the deployment, i.e. it will exceed the progress limit, will an error surface ?

Yes, with that PR, the Deployment status surfaces transitively via the Integration readiness condition, into the KameletBinding readiness condition.

[lburgazzoli]

Yes. I didn't change the KameletBinding phases, but I'd be inclined to eventually change the Ready phase to Running.

So I guess at this point, to monitor the kamelet binding we can almost ignore the phase and only rely on the conditions right ?

[astefanutti]

Yes. I didn't change the KameletBinding phases, but I'd be inclined to eventually change the Ready phase to Running.

So I guess at this point, to monitor the kamelet binding we can almost ignore the phase and only rely on the conditions right ?

Right, in the KameletBinding case, that only has one condition, the phase is reduced to a condensed version of the readiness condition.