Let Golang testing framework clean any temporary data #6251
+69
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: - apache#6192 Changes: - temporary files created during tests are placed in a temporary directory deleted by the testing framework - all the top-level temporary directories created for the tests are now deleted by the testing framework - pattern in the temporary directory is lost as the testing framework does not allow to add the pattern, hence we use the default temp dir name - test 'TestPermissionDenied' changes the file permissions to the temporary directory, therefore we need to change it back so that the testing framework can delete the folder
squakez
approved these changes
Sep 1, 2025
Contributor
squakez
left a comment
squakez
left a comment
There was a problem hiding this comment.
Excellent work, thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
t.TempDir()in unit test #6192Changes:
TestPermissionDeniedchanges the file permissions to the temporary directory, therefore we need to change it back so that the testing framework can delete the foldermodeline_test.gothat useutil.WithTempDir(frompkg/util/util.go:465) are untouched because I thought it was good to use this util method in tests as well, it indirectly verifies this util method and I don't see any downsideRelease Note