A pack of small Knative improvements #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
May 22, 2019
lburgazzoli
requested changes
May 22, 2019
pkg/trait/knative.go
Outdated
| @@ -101,6 +106,11 @@ func (t *knativeTrait) Configure(e *Environment) (bool, error) { | |||
|
|
|||
| t.EndpointSinks = strings.Join(items, ",") | |||
| } | |||
| if t.FilterSourceChannels == nil && len(strings.Split(t.ChannelSources, ",")) > 1 { | |||
There was a problem hiding this comment.
I think this should be an or because in case FilterSourceChannels is false but the number of sources is greater than two, then each from would receive a message for every subscribed channel
|
Should be fixed @lburgazzoli |
lburgazzoli
approved these changes
May 22, 2019
|
@nicolaferraro there's a conflict |
… knative service
…e with more than 2 channels
nicolaferraro
force-pushed
the
knative-improvements
branch
from
582e286 to
ccb26dc
Compare
|
Resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #663
Fix #668
Fix #669
Subscription to multiple channels works as long as the message travels only one channel. Should be fixed when we solve apache/camel-k-runtime#69.