feat: Set env var with Kamel #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #606
In terms of the potential for users to break things with this feature, I think we've ended up with an ok compromise.
Since the configuration of environment variables from traits etc, comes after those provided from 'kamel run', it results in those values taking precedence over the user provided ones. I think that's acceptable in the majority of cases.
E.g. If someone did
kamel run simple.js -e JAVA_MAIN_CLASS=some.invalid.Thing, thenJAVA_MAIN_CLASSwould get ignored and restored to the camel-k default.