-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to provide custom settings.xml #720
Conversation
if len(o.repositories) > 0 { | ||
o.mavenSettings = fmt.Sprintf("configmap:%s-maven-settings/settings.xml", platform.Name) | ||
|
||
settings := maven.NewSettings() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we generate the settings file, we may want to handle the local repository the same way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem is still the same, what if the user does not set it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it's still need a merge strategy, which can be addressed later.
@astefanutti @nicolaferraro it is now ready for review |
Fixes #715
Fixes #706
Support custom settings.xml via configmap/secret as well as some shortcuts to ease the installation process.
To configure the maven settings at installation time, one can use the
--maven-settings
option:To quickly set up maven repositories at installation time:
NOTES:
repository
option has been renamed tomaven-repository
maven-repository
andmaven-settings
are mutually exclusiverepository
option is not more available when running an integration