Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf-regression: introduce version specific build options #4436

Closed
ppalaga opened this issue Jan 24, 2023 · 3 comments
Closed

perf-regression: introduce version specific build options #4436

ppalaga opened this issue Jan 24, 2023 · 3 comments
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Jan 24, 2023

When trying to compare 2.13.1 with 2.13.2 using

java -jar target/quarkus-app/quarkus-run.jar -an 2.13.1 2.13.2

I see 2.13.2 failing due to oracle/graal#5303.

There is a known workaround to use Mandrel image. As far as I can see, there is currently no way to override the builder image for one (preferred) or both of the versions from the command line. I wonder whether it would be possible to introduce such an option.

Actually, for this particular situation, it would be enough to pass -Dquarkus.native.builder-image=mandrel both version builds. But being able to set the options for the individual builds separately would be more flexible.

@aldettinger
Copy link
Contributor

aldettinger commented Jan 24, 2023

Trying to summarize, oracle/graal#5303 occurs on some specific environments and has been fixed in native-image 22.3.1.
Trying to summarize, this issue occurs in camel-quarkus 2.13.2 and not camel-quarkus 2.13.1.
And, we could workaround with an option that would test with mandrel like --enable-mandrel.

The tool makes a strong assumption that all camel-quarkus sampled versions are built/tested under similar setup in order to maximize chances to catch meaningful regressions only. So I would advocate to setmandrel builder image for all versions under performance regression test.

Moreover, I think this option could be interesting on the long run. Even when testing native-mage <= 22.3.1 would not make sense anymore.

@aldettinger
Copy link
Contributor

Ok, I've implemented the option. Let's see how it goes.

@aldettinger aldettinger added this to the 2.17.0 milestone Jan 27, 2023
@ppalaga
Copy link
Contributor Author

ppalaga commented Jan 30, 2023

Thanks a lot, @aldettinger !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants