Update mvnd.builder.rules #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous iteration failed on a dependency download again. Lets try with |
Merged
|
You probably need to add somewhere what mvnd is and what's the meaning of the rules |
This is to enable retries even on dependency downloads where the request was sent successfully
|
Added comments in a8526df |
|
LGTM @ppalaga Wonder if mvnd should have a way to extend through service loader mechanism so one could contribute a logic to compute the rules without polluting the poms |
|
Sounds interesting. Would you mind proposing it via https://github.com/gnodet/mvnd/issues/new ? |
|
maven download seems very unstable |
oscerd
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.