Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error test already covered by unit tests for CASSANDRA-19341 #259

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Remove error test already covered by unit tests for CASSANDRA-19341 #259

wants to merge 3 commits into from

Conversation

blerer
Copy link
Contributor

@blerer blerer commented Mar 22, 2024

No description provided.

ekaterinadimitrova2
ekaterinadimitrova2 reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ekaterinadimitrova2 ekaterinadimitrova2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few tiny comments around versioning as these tests are run for all branches

json_test.py Show resolved Hide resolved
cql_test.py Show resolved Hide resolved
maedhroz
maedhroz approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@maedhroz maedhroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming outstanding comments are resolved one way or another (even if that's just correcting my ignorance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekaterinadimitrova2 ekaterinadimitrova2 ekaterinadimitrova2 approved these changes

@maedhroz maedhroz maedhroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blerer @maedhroz @ekaterinadimitrova2