Skip to content

Commit

Permalink
Revert "Revert "We can remove NioSocketChannel at least... possibly o…
Browse files Browse the repository at this point in the history
…thers as well. These were likely required in previous versions of""

This reverts commit 3cdf5fe.

Hmmm, a revert of a revert.. those are always tasty.

Original revert was motivated by the appearance of helidon-io/helidon#1722 in the Helidon test case.  Thing is
this can't be reproduced in non-Helidon contexts with the same GraalVM version.  And it's definitely the case that a no-arg
constructor is present (see
https://github.com/netty/netty/blob/netty-4.1.60.Final/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java).
So... this looks to be something unique to Helidon.
  • Loading branch information
absurdfarce committed Jul 23, 2021
1 parent 3cdf5fe commit ea52580
Showing 1 changed file with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,6 @@
"allDeclaredMethods": true,
"allPublicMethods": true
},
{
"name": "io.netty.channel.socket.nio.NioSocketChannel",
"allDeclaredConstructors": true,
"allPublicConstructors": true,
"allDeclaredMethods": true,
"allPublicMethods": true
},
{
"name": "io.netty.buffer.AbstractByteBufAllocator",
"allDeclaredConstructors": true,
Expand Down

0 comments on commit ea52580

Please sign in to comment.