Skip to content

CASSANDRA-15321 replace SNAPSHOT dependencies with STABLE#358

Closed
velo wants to merge 2 commits intoapache:trunkfrom
velo:dependency_tree
Closed

CASSANDRA-15321 replace SNAPSHOT dependencies with STABLE#358
velo wants to merge 2 commits intoapache:trunkfrom
velo:dependency_tree

Conversation

@velo
Copy link
Contributor

@velo velo commented Sep 9, 2019

Hi peeps,

I just noticed that for cassandra 4.0-alpha1, the cassandra-all has a dependency to chronicle-core version 1.16.3-SNAPSHOT.

http://repo1.maven.org/maven2/org/apache/cassandra/cassandra-all/4.0-alpha1/cassandra-all-4.0-alpha1.pom

Snapshots versions are not available on maven central, meaning cassandra-all can't be used as dependency for maven projects as is

@velo
Copy link
Contributor Author

velo commented Sep 9, 2019

I also noticed cassandra-driver being SNAPSHOT and moved to use the release. And, that carrotsearch was missing from the dependency list. Added.

@velo velo changed the title Move chronicle-core version from SNAPSHOT to STABLE CASSANDRA-15321 replace SNAPSHOT dependencies with STABLE Sep 9, 2019
@michaelsembwever michaelsembwever self-requested a review September 10, 2019 05:54
@michaelsembwever
Copy link
Member

build failure with the driver version change. looking into it…

@velo
Copy link
Contributor Author

velo commented Sep 10, 2019

@michaelsembwever where is the build being executed? Can I see the error?

@michaelsembwever
Copy link
Member

where is the build being executed? Can I see the error?

@velo if you do ant antifacts

@michaelsembwever
Copy link
Member

build failure with the driver version change. looking into it…

if you undo the java-driver change, will maven builds using cassandra-all work again @velo ?

(i don't believe the name of the jar files themselves impact the maven declared dependencies. the java-driver used is a problem, it contains a version and code that is not found anywhere on the java-driver github repository, but i believe this can be fixed separately and is not part of your breakage here.)

Currently, carrotsearch is only included on dependencyManagement section.
That only instruct maven about what versions should be used in case of conflicts.
But, do NOT instruct maven to actually use it as dependency.

So, need to include carrotsearch on the dependency list as well, since seems to be used across multiple classes in cassandra
@velo
Copy link
Contributor Author

velo commented Sep 21, 2019

if you undo the java-driver change, will maven builds using cassandra-all work again @velo ?

Yeah, I think that would be good enough for me.

BTW, replacing /lib folder with https://ant.apache.org/ivy/ would prevent this problem (and the cassandra driver one) from ever happening again.

@asfgit asfgit closed this in bc5fc8b Sep 22, 2019
@velo velo deleted the dependency_tree branch September 22, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants