Fix mutation tracking startup #4065
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch by Aleksey Yeschenko; reviewed by Blake Eggleston for CASSANDRA-20321
patch by Aleksey Yeschenko; reviewed by Blake Eggleston for CASSANDRA-20353
Patch by Blake Eggleston & Aleksey Yeshchenko Reviewed by Blake Eggleston, Aleksey Yeshchenko, & Abe Ratnofsky for CASSANDRA-20304, CASSANDRA-20305, & CASSANDRA-20308 Co-authored-by: Blake Eggleston <blake@ultrablake.com> Co-authored-by: Aleksey Yeschenko <aleksey@apache.org>
…st_describe_schema_output
aratno
approved these changes
Apr 8, 2025
| .afterReplay(Startup::scrubDataDirectories, | ||
| (metadata) -> StorageService.instance.registerMBeans()) | ||
| (metadata) -> StorageService.instance.registerMBeans(), | ||
| MutationTrackingService.instance::start) |
Contributor
There was a problem hiding this comment.
MutationTrackingService depends on schema being ready (so we can initialize shards for tracked keyspaces) and internode messaging / native protocol messaging to not be started yet (so we don't receive queries). Any other dependencies for why it has to be started here?
Member
Author
There was a problem hiding this comment.
The reason for initializing it via TCM in the first place was because the local node id wasn't always available when we tried to start the tracking service
bdeggleston
force-pushed
the
cep-45-mutation-tracking
branch
4 times, most recently
from
510053a to
a5f7e08
Compare
asf-gitbox-commits
force-pushed
the
cep-45-mutation-tracking
branch
from
d946c22 to
6430d49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.