CASSANDRA-20996 Use LWTs for all auto-repair history mutations #4456
+52
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzalys
changed the title
Contributor
Author
|
@jaydeepkumar1984 can I have a review on this please? |
test/unit/org/apache/cassandra/repair/autorepair/AutoRepairUtilsTest.java
Show resolved
Hide resolved
| @@ -538,4 +538,42 @@ public void testSkipSystemTraces() | |||
| { | |||
| assertFalse(AutoRepairUtils.shouldConsiderKeyspace(Keyspace.open(SchemaConstants.TRACE_KEYSPACE_NAME))); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testAutoRepairHistoryOutOfOrderDeleteRaceCondition() | |||
Contributor
There was a problem hiding this comment.
This test passes even without any of the changes because ADD_HOST_ID_TO_DELETE_HOSTS already had IF EXISTS, however, the changes in this PR are necessary.
Please clarify in the description that the PR includes the test case and a certain cases we missed earlier.
Contributor
Author
There was a problem hiding this comment.
Good point, I've extended this test to include cases that make this test fail without the changes in this PR.
Contributor
Author
There was a problem hiding this comment.
Also, updated the description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue https://issues.apache.org/jira/browse/CASSANDRA-20996
The auto-repair history management mechanism does not use LWTs for all of its history table queries. As a result, it is possible to run into a few edge cases where a deleted node's repair history gets resurrected. For example:
This can lead to the following race condition:
This PR introduces a unit test to simulate these out-of-order deletions/upserts and updates the auto-repair history mutations to use LWTs in order to prevent the race conditions from happening.