Skip to content

Conversation

@zwangsheng
Copy link
Contributor

@zwangsheng zwangsheng commented Jan 11, 2023

What changes were proposed in this pull request?

According to those following: we should move ./docker/helm => ./charts/celeborn

Why are the changes needed?

The changes are needed to be compliant with Helm recommendations:

https://helm.sh/docs/topics/charts/#the-chart-file-structure

The directory name is the name of the chart (without versioning information).
Thus, a chart describing WordPress would be stored in a wordpress/ directory.

https://helm.sh/docs/howto/chart_releaser_action/#repository-changes

The charts should be placed under /charts directory at the top-level of the directory tree.

Also according to apache/kyuubi#4034

Does this PR introduce any user-facing change?

How was this patch tested?

popo_2023-01-11  16-11-16

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1160 (a908249) into main (810a8d0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1160   +/-   ##
=========================================
  Coverage     26.88%   26.88%           
  Complexity      747      747           
=========================================
  Files           200      200           
  Lines         17022    17022           
  Branches       1838     1838           
=========================================
  Hits           4574     4574           
  Misses        12151    12151           
  Partials        297      297           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@waitinfuture waitinfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@waitinfuture waitinfuture merged commit 2bb8e7a into apache:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants