[CELEBORN-1316] Override toString method for StoreVersion#2372
Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-1316] Override toString method for StoreVersion#2372SteNicholas wants to merge 1 commit intoapache:mainfrom
SteNicholas wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
cc @waitinfuture, @FMX, @cxzl25. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2372 +/- ##
==========================================
+ Coverage 48.72% 48.74% +0.02%
==========================================
Files 209 209
Lines 13014 13014
Branches 1121 1121
==========================================
+ Hits 6340 6342 +2
+ Misses 6263 6262 -1
+ Partials 411 410 -1 ☔ View full report in Codecov by Sentry. |
cxzl25
approved these changes
Mar 9, 2024
FMX
approved these changes
Mar 11, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.5.0).
FMX
approved these changes
Mar 11, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.5.0).
SteNicholas
added a commit
that referenced
this pull request
Apr 23, 2024
### What changes were proposed in this pull request? Override `toString` method for `StoreVersion`. ### Why are the changes needed? Avoid displaying `StoreVersionhashCode` in the `IOException` thrown after the checkVersion check fails in `RocksDBProvider`/`LevelDBProvider`, show something like: ``` cannot read state DB with version org.apache.celeborn.service.deploy.worker.shuffledb.StoreVersion1f, incompatible with current version org.apache.celeborn.service.deploy.worker.shuffledb.StoreVersion3e ``` Backport apache/spark#44624. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - `DBProviderSuiteJ` Closes #2372 from SteNicholas/CELEBORN-1316. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Override
toStringmethod forStoreVersion.Why are the changes needed?
Avoid displaying
StoreVersionhashCodein theIOExceptionthrown after the checkVersion check fails inRocksDBProvider/LevelDBProvider, show something like:Backport apache/spark#44624.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
DBProviderSuiteJ