[CELEBORN-1392] TransportClientFactory should regard as zero for negative celeborn.<module>.io.connectTimeout/connectionTimeout #2467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive celeborn.<module>.io.connectTimeout/connectionTimeout
mridulm
approved these changes
Apr 19, 2024
FMX
approved these changes
Apr 19, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Merged into main(v0.5.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TransportClientFactoryshould regard as zero for negativeceleborn.<module>.io.connectTimeoutandceleborn.<module>.io.connectionTimeout.Why are the changes needed?
When
celeborn.<module>.io.connectionTimeoutis 0 that means unlimited to netty,ChannelFuture.await(0)fails directly and inappropriately. Meanwhile, whhenceleborn.<module>.io.connectionTimeoutis less than 0 that causes meaningless transport client reconnections and endless reconstructions.Backport:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
TransportClientFactorySuiteJ#unlimitedConnectAndConnectionTimeouts