-
Notifications
You must be signed in to change notification settings - Fork 408
[CELEBORN-2211] Avoid allocating additional buffers When HdfsFlushTask writes data #3548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Could you take some time to review this PR? @FMX |
|
@xy2953396112 @RexXiong Just hold on a moment, I'll review this PR this Saturday. |
|
@xy2953396112 I remember that your hdfs client is optimized and will not create a thread in the output stream but the oss client can not achieve that. |
FMX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be good choice for the oss hdfs client but I think it will be beneficial if you add a config for this.
a8a723b to
ff9ad7f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3548 +/- ##
==========================================
+ Coverage 67.05% 67.12% +0.08%
==========================================
Files 357 357
Lines 21779 21808 +29
Branches 1930 1930
==========================================
+ Hits 14602 14637 +35
+ Misses 6160 6156 -4
+ Partials 1017 1015 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@FMX PTAL, thanks~ |
ff9ad7f to
bfe91d4
Compare
bfe91d4 to
1ac943e
Compare
What changes were proposed in this pull request?
Initialize the
FSDataOutputStreamin theDfsTierWriter, use it for data writing when theHdfsFlushTaskperforms flushing, and close theFSDataOutputStreamwhen executingcloseStreams.Why are the changes needed?
Avoid allocating additional buffers When HdfsFlushTask writes data.
Does this PR resolve a correctness bug?
NO
Does this PR introduce any user-facing change?
NO
How was this patch tested?
CI