[REFACTOR] Switch docker base image to Eclipse Temurin #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Sep 2, 2022
docker/Dockerfile
Outdated
| apt install -y bash tini sshpass openssh-client vim bind9-utils telnet net-tools procps && \ | ||
| rm /bin/sh && \ | ||
| ln -sv /bin/bash /bin/sh && \ | ||
| echo "auth required pam_wheel.so use_uid" >> /etc/pam.d/su && \ |
docker/Dockerfile
Outdated
| RUN chmod +x /usr/bin/tini | ||
| RUN set -ex && \ | ||
| apt-get update && \ | ||
| ln -s /lib /lib64 && \ |
Contributor
Author
There was a problem hiding this comment.
According to apache/spark#25255 this PR, maybe we don't need this.
| ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /usr/bin/tini | ||
| RUN chmod +x /usr/bin/tini | ||
| RUN set -ex && \ | ||
| apt-get update && \ |
Member
There was a problem hiding this comment.
do we want to use aliyun mirror?
Contributor
Author
There was a problem hiding this comment.
+1 for build speed
Member
|
maybe arthas could be included in the docker image as well, WDYT? @waitinfuture @AngersZhuuuu |
Contributor
Contributor
|
Has this been tested? |
Contributor
Author
I had build docker images by this Dockerfile. I will test in kubernetes env. And pause some screenshoot later. |
Contributor
|
I meet a problem in this Dockerfile: |
Contributor
Author
|
|
pan3793
approved these changes
Sep 7, 2022
Contributor
|
Please have a test ping @fanyilun |
Contributor
|
It looks good to me now, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[REFACTOR] Switch docker base image to Eclipse Temurin
What changes were proposed in this pull request?
To close #508 & #381
Why are the changes needed?
According to docker-library/openjdk#505
What are the items that need reviewer attention?
Related issues.
Related pull requests.
How was this patch tested?
/cc @pan3793
/assign @main-reviewer