Fix: Illegal PGnotify declaration

Change the declaration `struct PGnotify` to `struct pgNotify`, which will make compile error when third part extension include header `cdbdispatchresult.h`.
apache · Dec 8, 2023 · 9ef1938 · 9ef1938
1 parent d39ed5c
commit 9ef1938
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/backend/cdb/dispatcher/cdbdisp_async.c b/src/backend/cdb/dispatcher/cdbdisp_async.c
@@ -1195,7 +1195,7 @@ processResults(CdbDispatchResult *dispatchResult)
 		else if (strcmp(qnotifies->relname, CDB_NOTIFY_ENDPOINT_ACK) == 0)
 		{
 			qnotifies->next = (struct pgNotify *) dispatchResult->ackPGNotifies;
-			dispatchResult->ackPGNotifies = (struct PGnotify *) qnotifies;
+			dispatchResult->ackPGNotifies = qnotifies;
 
 			/* Don't free the notify here since it in queue now */
 			qnotifies = NULL;

diff --git a/src/include/cdb/cdbdispatchresult.h b/src/include/cdb/cdbdispatchresult.h
@@ -24,7 +24,7 @@ struct pg_result;                   /* PGresult ... #include "libpq-fe.h" */
 struct SegmentDatabaseDescriptor;   /* #include "cdb/cdbconn.h" */
 struct StringInfoData;              /* #include "lib/stringinfo.h" */
 struct PQExpBufferData;             /* #include "libpq-int.h" */
-struct PGnotify;                    /* PGnotify ... #include "libpq-fe.h" */
+struct pgNotify;                    /* PGnotify ... #include "libpq-fe.h" */
 
 typedef struct CdbPgResults
 {
@@ -123,7 +123,7 @@ typedef struct CdbDispatchResult
 	 * queue for acknowledge NOTIFY messages, get freed for
 	 * each cdbdisp_waitDispatchAckMessage call
 	 */
-	struct PGnotify *ackPGNotifies;
+	struct pgNotify *ackPGNotifies;
 } CdbDispatchResult;
 
 /*