Fix regress test line no failures #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjhjstz
approved these changes
Aug 1, 2023
|
|
wfnuser
approved these changes
Aug 1, 2023
These two tests(exttableext and task) will print the line no of functions in regress test. But it may get different results in different OS, like Ubuntu and Kylin. So just remove the line-no output in tests. It has no effect on the correctness of the results.
roseduan
force-pushed
the
fix_regress_line_failures
branch
from
8b3bf3e to
148360a
Compare
avamingli
approved these changes
Aug 7, 2023
my-ship-it
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change logs
These two tests(exttableext and task) will print the line no of functions in regress test. But it may get different results in different OS, like Ubuntu and Kylin.
So just remove the line-no output in tests. It has no effect on the correctness of the results.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallel