Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add warehouse grammar and GUC variable #111

Merged
merged 16 commits into from
Aug 10, 2023

Conversation

roseduan
Copy link
Contributor

@roseduan roseduan commented Aug 1, 2023

Change logs

Since we are going to support storage/compute/catalog separation, we
need to add a warehouse logic to the system. Then we can use the
warehouse clause to specify the warehouse for a SQL query. A warehouse
is a group of segments, and we can create/alter/delete a warehouse.

This commit does the following things:

  1. add the grammar for the warehouse clause.
  2. add the GUC variable for the current warehouse.
  3. add some fileter conditions for gp_segment_configuration table, since we
    need to filter out the segments that are not in the current warehouse.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2023

CLA assistant check
All committers have signed the CLA.

roseduan added 2 commits August 2, 2023 10:42
Since we are going to support storage/compute/catalog separation, we
need to add a warehouse logic to the system. Then we can use the
warehouse clause to specify the warehouse for a SQL query. A warehouse
is a group of segments, and we can create/alter/delete a warehouse.

This commit does the following things:

1. add the grammar for the warehouse clause.
2. add the GUC variable for the current warehouse.
3. add some fileter conditions for gp_segment_configuration table, since we
   need to filter out the segments that are not in the current warehouse.
@roseduan roseduan force-pushed the support_warehouse branch from d20575c to df282ff Compare August 2, 2023 02:42
@my-ship-it my-ship-it merged commit 16b0b9d into apache:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants