-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add warehouse grammar and GUC variable #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are going to support storage/compute/catalog separation, we need to add a warehouse logic to the system. Then we can use the warehouse clause to specify the warehouse for a SQL query. A warehouse is a group of segments, and we can create/alter/delete a warehouse. This commit does the following things: 1. add the grammar for the warehouse clause. 2. add the GUC variable for the current warehouse. 3. add some fileter conditions for gp_segment_configuration table, since we need to filter out the segments that are not in the current warehouse.
roseduan
force-pushed
the
support_warehouse
branch
from
August 2, 2023 02:42
d20575c
to
df282ff
Compare
my-ship-it
reviewed
Aug 3, 2023
my-ship-it
reviewed
Aug 3, 2023
my-ship-it
reviewed
Aug 7, 2023
my-ship-it
reviewed
Aug 7, 2023
HuSen8891
reviewed
Aug 7, 2023
HuSen8891
reviewed
Aug 8, 2023
HuSen8891
reviewed
Aug 8, 2023
my-ship-it
reviewed
Aug 8, 2023
my-ship-it
reviewed
Aug 8, 2023
HuSen8891
approved these changes
Aug 10, 2023
my-ship-it
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change logs
Since we are going to support storage/compute/catalog separation, we
need to add a warehouse logic to the system. Then we can use the
warehouse clause to specify the warehouse for a SQL query. A warehouse
is a group of segments, and we can create/alter/delete a warehouse.
This commit does the following things:
need to filter out the segments that are not in the current warehouse.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel