Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatible logerrors type in pg_exttable #116

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

Ray-Eldath
Copy link
Contributor

closes: #21


Change logs

This commit is directly cherry-picked from https://github.com/greenplum-db/gpdb/pull/14123.

logerrors type in pg_foreign_table has been changed from bool to char by design in GPDB7 to support log error persistence for external tables, and originally the logerrors of extension gp_exttable_fdw was changed accordingly. This PR changes the type back to preserve backward compatability.

Because the factual data are stored in pg_foreign_table and this PR only changes the display of the data, it should have no compatability implication.

Does this PR introduce any user-facing change?

No.

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Ray-Eldath Ray-Eldath force-pushed the fix-21 branch 2 times, most recently from 455238f to 9f0bdb0 Compare August 4, 2023 05:30
@Ray-Eldath
Copy link
Contributor Author

Ray-Eldath commented Aug 4, 2023

I reset the author of this PR from the original author of https://github.com/greenplum-db/gpdb/pull/14123 to just me. Don't know if this will cause problems. If so I can change it back.

@tuhaihe
Copy link
Member

tuhaihe commented Aug 4, 2023

I reset the author of this PR from the original author of greenplum-db/gpdb#14123 to just me. Don't know if this will cause problems. If so I can change it back.

Hi @Ray-Eldath, thanks for you to point this out. If we just cherry-pick the commits for the upstream without any changes, we should keep the original author and copyright information.

@Ray-Eldath
Copy link
Contributor Author

I reset the author of this PR from the original author of greenplum-db/gpdb#14123 to just me. Don't know if this will cause problems. If so I can change it back.

Hi @Ray-Eldath, thanks for you to point this out. If we just cherry-pick the commits for the upstream without any changes, we should keep the original author and copyright information.

but then there's a CLA issue.

@tuhaihe
Copy link
Member

tuhaihe commented Aug 4, 2023

but then there's a CLA issue.

@Ray-Eldath: Sorry to confuse you. The CLA is optional, and not required, especially for the upstream contributors. Their code is already under Apache License v2.0, for us, we have got the grant to redistribute them, so It's ok to ignore the CLA. Let's keep the original copyright information, thanks!

This commit is directly cherry-picked from Greenplum#14123.

"logerrors" type in pg_foreign_table has been changed from bool
to char *by design* in GPDB7 to support log error persistence
for external tables, and originally the "logerrors" of extension
gp_exttable_fdw was changed accordingly. This PR changes the
type back to preserve backward compatability.

Because the factual data are stored in pg_foreign_table and this
PR only changes the display of the data, it should have no
compatability implication.

See: Issue#21 <apache#21>
See: https://github.com/greenplum-db/gpdb/pull/14123
@Ray-Eldath Ray-Eldath requested a review from my-ship-it August 31, 2023 09:28
@my-ship-it my-ship-it merged commit bd3713e into apache:main Sep 1, 2023
@Ray-Eldath Ray-Eldath deleted the fix-21 branch September 4, 2023 01:32
baotingfang pushed a commit that referenced this pull request Dec 1, 2023
This commit is directly cherry-picked from Greenplum#14123.

"logerrors" type in pg_foreign_table has been changed from bool
to char *by design* in GPDB7 to support log error persistence
for external tables, and originally the "logerrors" of extension
gp_exttable_fdw was changed accordingly. This PR changes the
type back to preserve backward compatability.

Because the factual data are stored in pg_foreign_table and this
PR only changes the display of the data, it should have no
compatability implication.

See: Issue#21 <#21>
See: https://github.com/greenplum-db/gpdb/pull/14123

Co-authored-by: Yongtao Huang <yongtaoh@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix logerrors type in pg_exttable
5 participants