[FIXME] Wrong results on main branch for INDF query #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPDB_12_MERGE_FIXME: the following comparison query has an ORCA plan that relies on "IS NOT DISTINCT FROM" Hash Join, a variant that we likely have lost during the merge with upstream Postgres 12. Disable ORCA for this query
Issue: HASH Join(left, right, inner) removing NULL tuples when there is INDF in query.
The field hashqualclauses in HashJoin node holds the expressions "IS NOT DISTINCT FROM" that test for match. This is normally idential to hashclauses but differs in case of non-equijoin comparision.
While scanning the HashBucket we were using hashclauses so we missed the expressions with "IS NOT DISTINCT FROM".
closes: #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel